cicd: Enable additional linters #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
All existing code passes enabled linters with their specific configuration Configured to run linters on new code only. Commented out linters and/or configuration options can be enabled individually alongside needed code changes. Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
praveingk
approved these changes
Oct 3, 2023
kfirtoledo
reviewed
Oct 4, 2023
kfirtoledo
reviewed
Oct 4, 2023
kfirtoledo
approved these changes
Oct 4, 2023
orozery
requested changes
Oct 8, 2023
orozery
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables additional linters. The list represents (what I think is) a reasonable set of linters that should be run in CICD.
However, some linters are currently disabled in the
golangci.yamlconfiguration as the existing code does not pass the checks.Future PRs can update the linter set or their configuration by removing the commented out lines and setting
issues.new: falseingolangci.yamland then runningmake lintand fixing any reported issues. This work will tracked in a #61.