Support multiple controlplane replicas #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevran
approved these changes
Jun 26, 2024
| @@ -73,7 +73,9 @@ type PeerOptions struct { | |||
| ContainerRegistry string | |||
| // Tag represents the tag of the project images. | |||
| Tag string | |||
| // Dataplanes is the number of dataplanes to create. | |||
| // ControlplaneReplicas is the number of controlplanes to create. | |||
There was a problem hiding this comment.
q: at some point we may want to start grouping CP and DP configurations into a structure for each. That is:
type ControlPlane struct {
Replicas uint16
...
}
type DataPlane struct {
Type string
Replicas uint16
...
}
tests/e2e/k8s/suite.go
Outdated
| @@ -197,6 +197,7 @@ func (s *TestSuite) RunOnAllDataplaneTypes(test func(cfg *util.PeerConfig)) { | |||
| s.RunSubTest(dataplaneType, func() { | |||
| test(&util.PeerConfig{ | |||
| DataplaneType: dataplaneType, | |||
| Controlplanes: 1, | |||
There was a problem hiding this comment.
q: is there a way to make the zero value (i.e., replica count is not set) useful? Specifically, can it be used to maintain backward compatibility?
For example, since 0 replicas is not meaningful, treat that as user wanting only a single replica.
| @@ -185,6 +188,7 @@ func (o *PeerOptions) Run() error { | |||
| FabricCertificate: fabricCert, | |||
| PeerCertificate: peerCert, | |||
| CACertificate: caCert, | |||
| Controlplanes: o.ControlplaneReplicas, | |||
There was a problem hiding this comment.
if we maintain backward compatibility by defining that if replicas is not set at all (i.e., the zero value for uint16 is set by default) we treat it as if it was set to 1 - we can save changes across multiple files.
Somewhere we can say:
...
if controlplaneReplicas == 0 { // not set, use default replica count
controlplaneReplicas = 1
}
orozery
force-pushed
the
multiple-controlplanes
branch
from
90f3a32 to
f142b1b
Compare
This commit adds an option for deploying clusterlink with multiple controlplane replicas. Signed-off-by: Or Ozeri <[email protected]>
orozery
force-pushed
the
multiple-controlplanes
branch
from
f142b1b to
ca5864d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option for deploying clusterlink with multiple controlplane replicas.