Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/k8s.sh: Fix iperf server setup #71

Merged
merged 1 commit into from
Oct 8, 2023
Merged

tests/k8s.sh: Fix iperf server setup #71

merged 1 commit into from
Oct 8, 2023

Conversation

orozery
Copy link
Collaborator

@orozery orozery commented Oct 8, 2023

This PR fixes the iperf server setup.

@orozery orozery requested a review from elevran October 8, 2023 13:01
elevran
elevran approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is there a reason to run with -t when not running in automation?

@orozery
tests/k8s.sh: Fix iperf server setup
3b03bd3 
This commit fixes the iperf server setup.

Signed-off-by: Or Ozeri <[email protected]>
@orozery
Copy link
Collaborator Author

orozery commented Oct 8, 2023

question: is there a reason to run with -t when not running in automation?

What is the downside of not having -t?

@elevran
Copy link
Collaborator

elevran commented Oct 8, 2023

🤷‍♂️
Was just wondering if there was a reason to include it originally...

@elevran elevran merged commit b557c09 into clusterlink-net:main Oct 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevran elevran elevran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orozery @elevran