PetAI: Call IsPositiveSpell() with SpellEntry to avoid double lookup

cmangos · Nov 3, 2023 · cf988b4 · cf988b4
1 parent cef9c11
commit cf988b4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/game/AI/BaseAI/PetAI.cpp b/src/game/AI/BaseAI/PetAI.cpp
@@ -283,7 +283,7 @@ std::pair<Unit*, Spell*> PetAI::PickSpellWithTarget(Unit* owner, Unit* victim, C
         // 1. Not ready.
         // 2. Non-combat spells while in combat (f.e., Succubus's Lesser Invisibility).
         // 3. Combat spells while not in combat.
-        if (!spellInfo || !m_unit->IsSpellReady(*spellInfo) || (m_inCombat && IsNonCombatSpell(spellInfo)) || (!m_inCombat && !IsPositiveSpell(spellInfo->Id)))
+        if (!spellInfo || !m_unit->IsSpellReady(*spellInfo) || (m_inCombat && IsNonCombatSpell(spellInfo)) || (!m_inCombat && !IsPositiveSpell(spellInfo)))
             continue;
 
         Spell* spell = new Spell(m_unit, spellInfo, flags);