More robust extractor scripts #519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed MoveMapGen.sh to not run exclusively on bash
Other small changes: 1 - Fix check of output mmap folder before attempting to create it. 2 - Moved the wait call to be right after the sub-shell execution 3 - Changed a few pipes to tee to be output redirection instead to not cause double logging to the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Changed how the arguments passed to the executables (ad, vmap_extractor, etc) are prepared, so the script can accept client and output paths containing white-spaces.
Added a check to halt execution if
adhad an error, as to not proceed toMoveMapGen.shif map files were not properly extracted.Formatted both scripts using
shfmt -i 2to keep indentation consistent and making the scripts easier to read.All changes were tested in dash and bash.
Todo