Quest: Fixed the lack of quest's reputation spillover data #575
Conversation
I have added per quest reputation spillover data, and changed the code to utilize that data. Current changes are made to perfectly mimic previous behavior. The purpose of this commit is only to create basis for future changes of quest's reputation spillover.
|
Please name some sources for reference that this is needed. |
JJBcku
force-pushed
the
ReputationSpilloverFix
branch
from
6b13f68 to
0c9be8e
Compare
|
Here are a few of my sources: Seems to me like all discussion of quest's reputation gain from classic wow agree that some quest do not reward spillover reputation. |
|
TrinityCore/TrinityCore@0f7b9c6 here is the actual needed implementation. Was told this was added to client in original cataclysm and this is actually how its meant to work. I wont integrate it myself this core sync cycle but at least now i know its intent. If you have time, pls look at changing the pr accordingly. |
|
Hi, I have changed the code from using an on/off switch to a per reputation spillover mask. In your opinion is there something else I should include in this pull request? |
|
Have you tested this? |
|
I have done some test, so far everything seems to work correctly. If you want me to fully test it I can do it but it will take a day or two. |
|
I might pull this into my repository and test it as well. Thanks for the legwork. |
|
Hi @cpevors |
Co-Authored-By: killerwife <[email protected]>
Current code apply reputation spillover to all sources of reputation while quest reputation spillover is supposed to be determined separately for each quest. To fix this behavior I have added the ReputationSpillover column to quest_template and changed the code to utilize this information.
Current changes are made to perfectly mimic previous behavior. The purpose of this commit is only to create basis for future changes of quest's reputation spillover.