-Nowar fix: Bots now properly remove the at-war flag again with the '…

…nowar' strategy.
cmangos · Oct 4, 2024 · 4fdc890 · 4fdc890
1 parent 09b5a9f
commit 4fdc890
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/playerbot/strategy/actions/CheckValuesAction.cpp b/playerbot/strategy/actions/CheckValuesAction.cpp
@@ -43,21 +43,23 @@ bool CheckValuesAction::Execute(Event& event)
         ReputationMgr& mgr = bot->GetReputationMgr();
         for (auto & faction : mgr.GetStateList())
         {
-            uint32 id = faction.first;
+            uint32 factionId = faction.second.ID;
+            uint32 replistId = faction.first;
 
-            if (!mgr.IsAtWar(id))
-                continue;
 #ifdef MANGOSBOT_ZERO
             const FactionEntry* thisFactionEntry = sFactionStore.LookupEntry(id);
 #else
-            const FactionEntry* thisFactionEntry = sFactionStore.LookupEntry<FactionEntry>(id);
+            const FactionEntry* thisFactionEntry = sFactionStore.LookupEntry<FactionEntry>(factionId);
 #endif
 
+            if (!mgr.IsAtWar(factionId))
+                continue;
+
             if (!thisFactionEntry)
                 continue;
 
-            if (bot->GetReputationMgr().GetRank(thisFactionEntry) < REP_HOSTILE)
-                bot->GetReputationMgr().SetAtWar(id, false);
+            if (bot->GetReputationMgr().GetRank(thisFactionEntry) > REP_HATED)
+                bot->GetReputationMgr().SetAtWar(replistId, false);
         }
     }