Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the optional ability to learn spells from drops such as the ones from AQ20. And warlock pet training for all bots. #114

Closed
wants to merge 7 commits into from

Conversation

Pip1987
Copy link
Contributor

@Pip1987 Pip1987 commented Dec 27, 2024

Added an option in the configs to learn spells that are gained from drops in classic such as Arcane Brilliance or Gift of the Wild.

Modified GeneralActions functionbool InitializePetAction::isUseful() to include train all bot warlock pets IF autoLearnTrainerSpells is enabled.

@Pip1987 Pip1987 changed the title Added the optional ability to learn spells from drops not just trainers Added the optional ability to learn spells from drops such as the ones from AQ20. Dec 27, 2024
@Pip1987 Pip1987 changed the title Added the optional ability to learn spells from drops such as the ones from AQ20. Added the optional ability to learn spells from drops such as the ones from AQ20. And warlock pet training for all bots. Dec 28, 2024
@celguar
Copy link
Contributor

celguar commented Dec 28, 2024

I think you should specify when and what happens in config at least. Book spells are learned on randomise for all random bots lvl 60 already.

@celguar
Copy link
Contributor

celguar commented Dec 28, 2024

also not sure why cmath is needed to get item requiredClass. Is it how it's done in core files?

@Pip1987
Copy link
Contributor Author

Pip1987 commented Dec 28, 2024

also not sure why cmath is needed to get item requiredClass. Is it how it's done in core files?

I used cmath to break down the required class out of that's in base2 to the format that is in the core (ie required class for. rogue only item is 8, the class in the get class of a rogue returns 4. I don't know about core how it was done in the core I'll check on that and modify to the core structure.

@Pip1987
Copy link
Contributor Author

Pip1987 commented Dec 28, 2024

I think you should specify when and what happens in config at least. Book spells are learned on randomise for all random bots lvl 60 already.

I think I understand what your saying.

# Bots automatically learn class spells from books (such as the ones from AQ20)
Should read more
# Alt Bots automatically learn class spells from books dropped from dungeons and raids at the required level of the book.

Updated AutoLearnBookSpells description to show that randomly generated bots automatically do this.
@Pip1987
Copy link
Contributor Author

Pip1987 commented Dec 30, 2024

I've done another minor update to the description to help clarify that not only is the learn class spells from books is a alt bot thing but that also randomly generated bots automatically do this.

@Pip1987
Copy link
Contributor Author

Pip1987 commented Jan 1, 2025

I'm having to go through AutoLearnSpellAction and make some major changes. I'm going to close this PR and reopen once I get all the bot pets sorted.

@Pip1987 Pip1987 closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants