Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box to fresnel visualization #55

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

marjanalbooyeh
Copy link
Contributor

This PR adds the simulation box to the rendered images.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #55 (705ef73) into master (543a2c6) will increase coverage by 0.02%.
The diff coverage is 97.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files           8        8              
  Lines         606      636      +30     
==========================================
+ Hits          582      611      +29     
- Misses         24       25       +1     
Files Changed Coverage Δ
cmeutils/visualize.py 97.32% <97.05%> (-0.13%) ⬇️

Copy link
Member

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We just need a couple unit tests that checks if height is being set to the right values, and that self.scene.geometry contain the right objects depending on show_box

@marjanalbooyeh marjanalbooyeh merged commit 45fcd2d into cmelab:master Sep 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants