WIP: Fixes for EFT combination & RobustHesse parallelisation #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajgilbert
commented
Feb 22, 2024
ajgilbert
commented
- Some fixes to RooEFTScalingFunction
- Option to split RobustHesse calculation in parallel jobs (to be facilitated by combineTool.py)
- Some testing still needed, plus a workflow to merge output hessian matrices (maybe with standalone inversion and RooFitResult creation, since would be pointless to re-enter combine again?)
- Added --robustHesseSplit [N] --robustHesseIdx [i] options to combine - Set [N] to the number of jobs you want to run. Then in each job, set i to one of [0..N-1]. - Each job should process an equal chunk of the Hessian matrix - In each job, once the partial hessian is calculated, combine will continue and try to invert. Clearly this will fail most of the time, but we don't care. - Still to-do: write a script to combine the output Hessians, but should be trivial
…ussian constraints (for EFT Combination)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.