Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo JEC for subjets in FatJet #281

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/postprocessing/modules/jme/fatJetUncertainties.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ def analyze(self, event):
genGroomedSubJets = None
genGroomedJet = None
if jet.subJetIdx1 >= 0 and jet.subJetIdx2 >= 0:
groomedP4 = subJets[jet.subJetIdx1].p4() + subJets[
jet.subJetIdx2].p4() # check subjet jecs
groomedP4 = (subJets[jet.subJetIdx1].p4() * (1. - subJets[jet.subJetIdx1].rawFactor)) \
+ (subJets[jet.subJetIdx2].p4() * (1. - subJets[jet.subJetIdx2].rawFactor))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that the eta and phi of the jet are not affected? The raw factor should only be applied to the pt and mass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camclean Are you referring to eta and phi of the AK8 parent jet or each of the subjets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you get from groomedP4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attached slide shows pT, eta and phi distributions of subjet 1 (top) and subjet 2 (bottom). Black solid histogram is with JEC applied (by default in NanoAOD) and blue dashed histogram is without the JEC applied (as implemented by the fixed in this PR). The implementation does not affect the subjets' eta and phi variables.

SubJetKinematics_WithAndWithoutJEC.pdf

else:
groomedP4 = None

Expand Down