resolve comments

Signed-off-by: Alex Chi <[email protected]>

src/type/type.cpp

@@ -293,7 +293,7 @@ auto Type::GetData(const Value &val __attribute__((unused))) const -> const char
 
 // Get the length of the variable length data
 auto Type::GetStorageSize(const Value &val __attribute__((unused))) const -> uint32_t {
-  throw NotImplementedException("GetLength not implemented");
+  throw NotImplementedException("GetStorageSize not implemented");
 }
 
 }  // namespace bustub

test/sql/index.slt

@@ -0,0 +1,20 @@
+statement ok
+CREATE TABLE t1(v1 integer, v2 integer);
+
+statement ok
+INSERT INTO t1 VALUES (0, 0), (1, 1), (2, 2);
+
+statement ok
+CREATE INDEX t1v2a ON t1 (v2);
+
+statement ok
+CREATE INDEX t1v2b ON t1 USING bplustree (v2);
+
+statement ok
+CREATE INDEX t1v2c ON t1 USING hash (v2);
+
+statement ok
+CREATE INDEX t1v2d ON t1 USING stl_ordered (v2);
+
+statement ok
+CREATE INDEX t1v2e ON t1 USING stl_unordered (v2);

test/sql/vector.slt

@@ -3,18 +3,3 @@ CREATE TABLE t1(v1 VECTOR(3), v2 integer);
 
 statement ok
 INSERT INTO t1 VALUES (ARRAY [1.0, 1.0, 1.0], 232), (ARRAY [2.0, 1.0, 1.0], 233), (ARRAY [3.0, 1.0, 1.0], 234), (ARRAY [4.0, 1.0, 1.0], 235);
-
-statement ok
-CREATE INDEX t1v2a ON t1 (v2);
-
-statement ok
-CREATE INDEX t1v2b ON t1 USING bplustree (v2);
-
-statement ok
-CREATE INDEX t1v2c ON t1 USING hash (v2);
-
-statement ok
-CREATE INDEX t1v2d ON t1 USING stl_ordered (v2);
-
-statement ok
-CREATE INDEX t1v2e ON t1 USING stl_unordered (v2);