Skip to content

Commit

Permalink
small fix to tests_ci.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
wangpatrick57 committed Oct 30, 2024
1 parent b4da539 commit 2d00f95
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ jobs:
# Unit tests are defined as tests which don't require any external systems to be running.
run: |
. "$HOME/.cargo/env"
./scripts/run_unit_tests.py
./scripts/run_unit_tests.sh
- name: Run integration tests
# Integration tests do require external systems to be running (most commonly a database instance).
# Unlike end-to-end tests though, they test a specific module in a detailed manner, much like a unit test does.
run: |
. "$HOME/.cargo/env"
./scripts/run_integration_tests.py
./scripts/run_integration_tests.sh
- name: Run end-to-end tests
# End-to-end tests are like integration tests in that they require external systems to be running.
Expand Down
6 changes: 5 additions & 1 deletion tune/env/integtest_pg_conn.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ def setUpClass() -> None:
PostgresConnTests.dbgym_cfg = DBGymConfig(ENV_TESTS_DBGYM_CONFIG_FPATH)

def setUp(self) -> None:
self.assertFalse(get_is_postgres_running())
self.assertFalse(
get_is_postgres_running(),
"Make sure Postgres isn't running before starting the integration test. `pkill postgres` is one way" +
"to ensure this. Be careful about accidentally taking down other people's Postgres instances though."
)
self.pristine_dbdata_snapshot_path = default_pristine_dbdata_snapshot_path(
self.dbgym_cfg.dbgym_workspace_path, BENCHMARK, SCALE_FACTOR
)
Expand Down

0 comments on commit 2d00f95

Please sign in to comment.