now exporting INTENDED_DBDATA_HARDWARE as ssd

.github/workflows/tests_ci.yaml

@@ -50,8 +50,11 @@ jobs:
     - name: Run integration tests
       # Integration tests do require external systems to be running (most commonly a database instance).
       # Unlike end-to-end tests though, they test a specific module in a detailed manner, much like a unit test does.
+      #
+      # We set `INTENDED_DBDATA_HARDWARE` so that it's seen when `integtest_pg_conn.py` executes `./tune/env/set_up_env_integtests.sh`.
       run: |
         . "$HOME/.cargo/env"
+        export INTENDED_DBDATA_HARDWARE=ssd
         ./scripts/run_integration_tests.sh
 
     - name: Run end-to-end tests

tune/env/integtest_pg_conn.py

@@ -1,3 +1,4 @@
+import os
 import subprocess
 import unittest
 from pathlib import Path
@@ -33,6 +34,7 @@ class PostgresConnTests(unittest.TestCase):
 
     @staticmethod
     def setUpClass() -> None:
+        # If you're running the test locally, this check makes runs past the first one much faster.
         if not get_unittest_workspace_path().exists():
             subprocess.run(["./tune/env/set_up_env_integtests.sh"], check=True)
 

tune/env/set_up_env_integtests.sh

@@ -8,7 +8,8 @@
 
 set -euxo pipefail
 
-INTENDED_DBDATA_HARDWARE="${1:-hdd}"
+# INTENDED_DBDATA_HARDWARE can be set elsewhere (e.g. by tests_ci.yaml) but we use hdd by default.
+INTENDED_DBDATA_HARDWARE="${INTENDED_DBDATA_HARDWARE:-hdd}"
 BENCHMARK=tpch
 SCALE_FACTOR=0.01
 export DBGYM_CONFIG_PATH=tune/env/env_integtests_dbgym_config.yaml # Note that this envvar needs to be exported.