Memo trait #17
Merged
Memo trait #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortsui20
force-pushed
the
memo-trait
branch
from
9435a93 to
e5d9e91
Compare
connortsui20
force-pushed
the
memo-trait
branch
9 times, most recently
from
ceb1825 to
9b74ff7
Compare
connortsui20
force-pushed
the
memo-trait
branch
from
9b74ff7 to
42321c9
Compare
|
Let's make sure we squash commits before we merge. We can squash them into multiple commits if necessary. |
connortsui20
force-pushed
the
memo-trait
branch
from
ba8ff26 to
1fcef01
Compare
This commit adds a `Memo` trait and a first draft of an implementation of the `Memo` trait via the backed ORM-mapped database. pushing entities
SarveshOO7
force-pushed
the
memo-trait
branch
from
c05c180 to
5a08b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR adds a
Memotrait and a first draft of an implementation of theMemotrait via the backed ORM-mapped database.We use associated types to allow the implementor to define what the types they want to represent each concept.
There are a few todos still that I can't resolve myself, like how to add the children of both types of expressions into the ORM, since if you just have a JSON you can't figure it out on your own (unless you write something that is dependent on the variant tag).
Additionally, there are a few places where I arbitrarily choose to get IDs for a group or expression versus the entire tuple / record. I just chose what was easiest via the ORM, that can be easily changed if we need to.