This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
feat: using proper magic numbers in various edge cases #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perftest (due to with_logical flags being different)
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Using magic numbers from Postgres in various selectivity edge cases.
Demo:
Different (unfortunately worse) q-error on TPC-H SF1. See #127 for per-query details on how this PR affects q-error.
Details:
INVALID_SELis no longer used at all during cardtest. It is still used during plannertest as some plannertests use the optd optimizer instead of the datafusion logical optimizer. This can be checked by replacing all instances ofINVALID_SELwith apanic!()and seeing that cardtest still runs.LIKE.INVALID_SELwithpanic!()andunreachable!()statements in places where it makes sense.