-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2085 add proportions nhsn #2111
Merged
+348
−167
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ff91c4c
initial implimentation for proportion
aysim319 5ef99b2
in progress
aysim319 6b19402
check for update in progress
aysim319 ad92262
merged with main
aysim319 f4b3c40
adding checking updates in progress
aysim319 1df478c
adding just num reporting hospital
aysim319 6e5a99b
tests and undoing proportion signal code
aysim319 7cabd8a
lint
aysim319 6a73c35
fixed test
aysim319 6e0d4c2
fix test part 2
aysim319 2da6c08
fixed bugs related to patching added test for missing signal columns …
aysim319 1e408ba
suggestion
aysim319 77662dc
missed fix for test data
aysim319 783ab24
fixed test
aysim319 76d5436
suggested change
aysim319 18de943
changed logic to be cleaner; always create backups
aysim319 e3e96bf
lint
aysim319 e9bb0a7
wrapped in try block
aysim319 33f3db5
retrigger jenkin build
aysim319 88fbc6e
cleaned test and suggested changes
aysim319 7e6b23a
adding more context/comments for check update
aysim319 a220e0d
doc string fix
aysim319 d8f237b
fixed copy issue
aysim319 11ceae9
lint
aysim319 ebe52aa
Apply suggestions from code review
aysim319 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
adding checking updates in progress
commit f4b3c404294c73f23f6073baf50337fbab40615b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue:
pull_preliminary_nhsn_data
andpull_nhsn_data
are really similar. I think it will become a maintenance issue to keep both. We should probably keep these two functions as wrappers of a shared fn that takes ais_prelim
flag (or similar).Diff of the two fns:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know they're similar, i thought about it and went back and forth about it but I was in the thought of maybe in the future there would be something different going on so kept it seperate. I'm not too concerned about this, since we'll be slowly deprecating this codebase;