interest: fix timeout calculation for suite != NDN-TLV #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
force-pushed
the
pr_interest_timeout
branch
from
0c86bf2 to
92e797e
Compare
mfrey
requested changes
Feb 25, 2019
mfrey
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently, the lifetime for new interests is read from
pkt->s.ndntlv.interestlifetimeeven for packets that have an CCNx encoding. Sinces.ndntlvis a union in this case, it contains something, but definitely not the correct interest lifetime for CCNx. On the other hand, the CCNx parser does not really parse the interest lifetime hop-by-hop option. This patch adds an abstraction to figure out the suite and return the correct lifetime (s.ndntlv.interestlifetimefor NDN andCCNL_INTEREST_LIFETIMEfor CCNx and others).Issues/PRs references
Probably related to #210