Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parse Separations and Mixer archetypes properly #23

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nuclearkatie
Copy link
Member

@nuclearkatie nuclearkatie commented Jun 13, 2020

Parses Cycamore Separations and Mixer facilities separately than other archetypes due to different xml input schema. Previously, they would be parsed but with miss either input or output commodities (input for Mixer, output for Separations).

Closes #22

@nuclearkatie nuclearkatie requested a review from gonuke June 13, 2020 00:40
@gonuke
Copy link
Member

gonuke commented Jun 13, 2020

It would be good to add a test by changing your standard XML file to include a separations and mixer archetype.

We can also discuss some design elements here - might be really good for a S/W meeting!
Thinking ahead to other archetypes (e.g. not in cycamore) that might have unusual signatures, I wonder if there is a way to generalize this somewhat?

@nuclearkatie nuclearkatie changed the base branch from master to main June 13, 2020 19:51
@nuclearkatie
Copy link
Member Author

Agreed, I think there are several ways to do this and I chose the most straightforward simply because I wanted to immediately use the added ability to parse separations/mixer in an example problem. I can bring it to software this week

@nuclearkatie nuclearkatie marked this pull request as draft October 12, 2020 20:27
@nuclearkatie nuclearkatie changed the title Parse Separations and Mixer archetypes properly [WIP] Parse Separations and Mixer archetypes properly Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse_input cannot properly find commodities for Separations facility
2 participants