Use pimega library from system installation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLib is a dependency for other areaDetector modules, and it should be defined in the top-level areaDetector CONFIG_SITE.local. Let's use that instead of hard-coding deploy specific paths into src/Makefile.
Expect the library to be already installed in the system directories to simplify IOC build system and make the library version less coupled with support module. Since develop cycles happen in a high frequency now, this is being preferred over importing headers and binaries into a support module, as done in other areaDetector modules with proprietary SDKs. We need to explicitly define include directory for pimega library due to the usage of `#include ""` directives. By default, we expect headers to be installed under `pimega` directory, to avoid their generic subdirectories from conflicting with other application headers. This should be redefined in CONFIG_SITE.local to override the default value if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect the library to be already installed in the system directories to simplify IOC build system and make the library version less coupled with support module. Since develop cycles happen in a high frequency now, this is being preferred over importing headers and binaries into a support module, as done in other areaDetector modules with proprietary SDKs.
We need to explicitly define include directory for pimega library due to the usage of
#include ""directives. By default, we expect headers to be installed underpimegadirectory, to avoid their generic subdirectories from conflicting with other application headers. This should be redefined in CONFIG_SITE.local to override the default value if needed.While here, also make GLib be installed following the areaDetector top-level
CONFIG_SITE.