Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EDGEDRIVER_CDNURL env #50

Merged
merged 2 commits into from
May 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
f
fengmk2 committed May 11, 2024
commit ed3aea879a55f9b11677db4484e2a6707289409a
3 changes: 3 additions & 0 deletions test/index.test.js
Original file line number Diff line number Diff line change
@@ -154,6 +154,7 @@ describe('test/index.test.js', () => {
assert.deepStrictEqual(options, {
env: {
NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure consistency in the URL format for EDGEDRIVER_CDNURL.

- EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
+ EDGEDRIVER_CDNURL: 'https://cdn.npmmirror.com/mirrors/edgedriver',

The URL for EDGEDRIVER_CDNURL should match the format used for other CDN URLs in the project, which typically start with https://cdn.npmmirror.com. This change will ensure consistency across all environment variables.


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
EDGEDRIVER_CDNURL: 'https://cdn.npmmirror.com/mirrors/edgedriver',

COREPACK_NPM_REGISTRY: 'https://registry.npmmirror.com',
NVM_NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
PHANTOMJS_CDNURL: 'https://cdn.npmmirror.com/binaries/phantomjs',
@@ -227,6 +228,7 @@ describe('test/index.test.js', () => {
env: {
NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
NVM_NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
COREPACK_NPM_REGISTRY: 'https://registry.npmmirror.com',
PHANTOMJS_CDNURL: 'https://cdn.npmmirror.com/binaries/phantomjs',
CHROMEDRIVER_CDNURL: 'https://cdn.npmmirror.com/binaries/chromedriver',
@@ -304,6 +306,7 @@ describe('test/index.test.js', () => {
assert.deepStrictEqual(options.env, {
NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
COREPACK_NPM_REGISTRY: 'https://registry.npmmirror.com',
EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
NVM_NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node',
PHANTOMJS_CDNURL: 'https://cdn.npmmirror.com/binaries/phantomjs',
CHROMEDRIVER_CDNURL: 'https://cdn.npmmirror.com/binaries/chromedriver',