Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aplayer and meting #230

Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat: add aplayer and meting #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,6 +1811,9 @@
"apk-parser3": {
"version": "*"
},
"aplayer": {
"version": "*"
},
Comment on lines +1814 to +1816
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using wildcard (*) for versioning.

Using * for versioning can lead to potential compatibility and stability issues. It is recommended to specify a version range to ensure consistency and avoid breaking changes.

-    "aplayer": {
-      "version": "*"
+    "aplayer": {
+      "version": "^1.0.0"

Adjust the version range according to the project's compatibility requirements.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"aplayer": {
"version": "*"
},
"aplayer": {
"version": "^1.0.0"
},

"apmp": {
"version": "*"
},
Expand Down Expand Up @@ -9530,6 +9533,9 @@
"medium-zoom": {
"version": "*"
},
"meting": {
"version": "*"
},
Comment on lines +9536 to +9538
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using wildcard (*) for versioning.

Using * for versioning can lead to potential compatibility and stability issues. It is recommended to specify a version range to ensure consistency and avoid breaking changes.

-    "meting": {
-      "version": "*"
+    "meting": {
+      "version": "^1.0.0"

Adjust the version range according to the project's compatibility requirements.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"meting": {
"version": "*"
},
"meting": {
"version": "^1.0.0"
},

"mem": {
"version": "*"
},
Expand Down
Loading