-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pyodide #279
feat: add pyodide #279
Conversation
WalkthroughThe changes in this pull request involve the addition of a new dependency, "pyodide," to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
package.json (1)
18582-18584
: Analyze the impact and compatibility of adding the pyodide dependency.Adding the pyodide dependency enables running Python in the browser which can enhance the project's capabilities. However, as noted in the PR summary, the large wasm file size of pyodide may impact loading times and performance.
A few considerations:
- Ensure the use case justifies the addition of pyodide and its performance tradeoff. Analyze if Python execution in the browser is a core requirement.
- Test the integration to measure the actual performance impact. Consider lazy loading pyodide if possible.
- Verify browser compatibility and any other implications of shipping the large wasm file.
- Update documentation with guidance on how to effectively leverage pyodide.
Overall, the addition seems reasonable if Python in the browser is a key feature. But do weigh the tradeoffs carefully and optimize the integration.
[skip ci] ## [1.128.0](v1.127.0...v1.128.0) (2024-09-18) ### Features * add pyodide ([#279](#279)) ([0237068](0237068))
pyodide : https://github.com/pyodide/pyodide
this package can run a python runtime in the browser : https://pyodide.org/en/stable/console.html
but the cost is the large wasm file size.
Summary by CodeRabbit