Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add birpc, hookable and perfect-debounce #281

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: add birpc, hookable and perfect-debounce #281

merged 1 commit into from
Sep 19, 2024

Conversation

FuckDoctors
Copy link
Contributor

@FuckDoctors FuckDoctors commented Sep 19, 2024 •
edited by coderabbitai bot
Loading

Dependencies of @vue/devtools-kit.

https://github.com/vuejs/devtools-next/blob/7891be1eb0f00594ebdf5f9f7b3a1a6e4fbc9154/packages/devtools-kit/package.json#L32-L35

Summary by CodeRabbit

  • New Features
    • Introduced new dependencies to enhance application capabilities: birpc, hookable, and perfect-debounce.

@FuckDoctors
feat: add birpc, hookable and perfect-debounce
15250e7 
Dependencies of @vue/devtools-kit
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2024 •
edited
Loading

Walkthrough

The pull request introduces three new dependencies to the package.json file: birpc, hookable, and perfect-debounce. Each dependency is specified with a version of "*", allowing for the use of any version of these packages. This update enhances the project's functionality by incorporating additional libraries without altering existing code or logic.

Changes

File Change Summary
package.json Added dependencies: birpc, hookable, perfect-debounce with version "*" for each.

Possibly related PRs

🐇 In the meadow, new friends arrive,
Birpc, Hookable, and Perfect Debounce thrive.
With each new package, our project will grow,
Hopping along, watch our features glow!
Dependencies added, oh what a delight,
Coding together, everything feels right! 🌼✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c4d6cc and 15250e7.

Files selected for processing (1)
  • package.json (1 hunks)
Additional comments not posted (1)
package.json (1)

18620-18628: Use a specific version range instead of "*".

Using "*" as the version means any version of the dependency can be installed, which can lead to inconsistent builds across different environments. It's recommended to use a specific version or version range instead.

That said, the addition of birpc, hookable, and perfect-debounce dependencies aligns with the PR objective of introducing new dependencies related to @vue/devtools-kit.

To verify the usage of the new dependencies in the codebase, you can run the following script:

This will search for import statements of birpc, hookable, and perfect-debounce in JavaScript files, and also check if @vue/devtools-kit is using these dependencies.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fengmk2 fengmk2 merged commit 28b3ff9 into cnpm:master Sep 19, 2024
4 checks passed
fengmk2 pushed a commit that referenced this pull request Sep 19, 2024
@semantic-release-bot
Release 1.130.0
73a8f9a 
[skip ci]

## [1.130.0](v1.129.0...v1.130.0) (2024-09-19)

### Features

* add birpc, hookable and perfect-debounce ([#281](#281)) ([28b3ff9](28b3ff9)), closes [/github.com/vuejs/devtools-next/blob/7891be1eb0f00594ebdf5f9f7b3a1a6e4fbc9154/packages/devtools-kit/package.json#L32-L35](https://github.com/cnpm//github.com/vuejs/devtools-next/blob/7891be1eb0f00594ebdf5f9f7b3a1a6e4fbc9154/packages/devtools-kit/package.json/issues/L32-L35)
@FuckDoctors
Copy link
Contributor Author

@fengmk2 你好，貌似没起作用，能麻烦看下怎么回事吗？
谢谢！

https://registry.npmmirror.com/hookable/5.5.3/files/dist/index.mjs
https://registry.npmmirror.com/birpc/0.2.17/files/dist/index.mjs
https://registry.npmmirror.com/perfect-debounce/1.0.0/files/dist/index.mjs

@FuckDoctors
Copy link
Contributor Author

@fengmk2 终于生效了，请无视。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuckDoctors @fengmk2