Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle xdisplay null #53

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Handle xdisplay null #53

merged 2 commits into from
Feb 7, 2019

Conversation

dreua
Copy link
Member

@dreua dreua commented Feb 7, 2019

Prints a warning and gracefully exits instead of segmentation fault.
This can happen e.g. using SSH or in text mode.

dreua added 2 commits February 7, 2019 12:39
Prints a warning and grecefully exits instead of segmentaiton fault.
This can happen e.g. using SSH or in text mode.
@dreua
Copy link
Member Author

dreua commented Feb 7, 2019

Related issue: #26

@cnlohr
Copy link
Member

cnlohr commented Feb 7, 2019

Merging, also trying to merge into the rawdraw backend in cntools to further its use. Thanks, @dreua If you get a chance check out https://github.com/cnlohr/rawdraw/ and see if you can make similar mods there. It would be very cool to have more than one contributor on that project.

@cnlohr cnlohr merged commit afcc565 into cntools:master Feb 7, 2019
@dreua dreua deleted the handle_xdisplay_null branch February 8, 2019 00:59
@dreua
Copy link
Member Author

dreua commented Feb 8, 2019

I wasn't aware of the separate rawdraw repository. Ideally rawdraw would be a git submodule of cnping, wouldn't it? meld cnping/ rawdraw/ (directories being the obvious clones) shows that there is a common codebase but it's sometimes hard to tell which version is better so merging these back together might be rather hard and possibly not worth it. Anyway, I am aware of rawdraw and watching the repository now, so I'll have a look at issues there if they come up.

@cnlohr
Copy link
Member

cnlohr commented Feb 8, 2019

It would be, the problem was both started different, and no serious effort has been made to attempt re-merge. All other projects which use rawdraw do use it as an external module.

That might be a weekend project for me one of these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants