Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge html css et accessibilité #27

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

doydoy44
Copy link
Contributor

Merci à @hrenaud pour sa PR qui m'a bien aidée.

webpack.config.js Outdated Show resolved Hide resolved
src/ts/ecoindex-badge.ts Show resolved Hide resolved
src/ts/ecoindex-badge.ts Outdated Show resolved Hide resolved
src/ts/ecoindex-badge.ts Outdated Show resolved Hide resolved
src/ts/ecoindex-badge.ts Outdated Show resolved Hide resolved
@vvatelot
Copy link
Member

🎯 suggestion(non-blocking): Je pense qu'en passant à cette version html, on peut supprimer le répertoire assets/svg qui n'a plus lieu d'être. Sinon ça me parait propre !

Il faudra que l'on créé une version V3.0.0

@github-actions github-actions bot removed the Stale label Sep 1, 2023
@doydoy44
Copy link
Contributor Author

doydoy44 commented Sep 4, 2023

@vvatelot , j'ai l'impression que le assets/svg est utilisé ailleurs comme dans l'ecoindex_bff pour ceux qui utilisent le bage sans le js :
https://github.com/cnumr/ecoindex_bff/blob/main/services/badge.go#L30C24-L30C24
Dans le doute je l'ai laissé

@vvatelot
Copy link
Member

vvatelot commented Sep 5, 2023

En fait ça ira: Ceux qui utiliseront la v2 comme spécifié précédemment dans la doc utiliseront toujours la v2 qui gardera, elle, le dossier svg... Donc ça marche !
Ce qui me fait penser, si on fait ça, il faut mettre à jour le readme en pointant sur la (future) v3:

<div id="ecoindex-badge"></div>
<script src="https://cdn.jsdelivr.net/gh/cnumr/ecoindex_badge@3/assets/js/ecoindex-badge.js" defer></script>

Par exemple...

@github-actions github-actions bot added the Stale label Oct 12, 2023
@github-actions github-actions bot closed this Oct 17, 2023
@vvatelot vvatelot reopened this Oct 25, 2023
@vvatelot vvatelot removed the Stale label Oct 25, 2023
@vvatelot vvatelot merged commit cc009fc into cnumr:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants