Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More library additions #1243

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

YarinHeffes
Copy link
Collaborator

@YarinHeffes YarinHeffes commented Sep 13, 2024

To be broken down into individual PRs and then closed.

Progress:

@YarinHeffes YarinHeffes force-pushed the more-library-additions branch from a0840eb to 08709e4 Compare September 17, 2024 18:47
Copy link
Collaborator

@Izaakwltn Izaakwltn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good-

I'm ready to approve it with

  1. An adjusted commit history (squash merges, reverts, wip commits)
  2. add some tests for new functions, especially in ord-tree and ord-map, potentially for try-as and unwrap-as as well

@@ -218,12 +218,14 @@ does not have that suffix."
(define-instance (Into Single-Float String)
(define (into z)
(lisp String (z)
(cl:prin1-to-string z))))
(cl:format cl:nil "~F" z)
#+ign(cl:prin1-to-string z))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ignores

@YarinHeffes YarinHeffes marked this pull request as draft December 27, 2024 23:06
@stylewarning
Copy link
Member

I think we'll want to break this PR up into a few logical chunks. Large sweeping library additions of unrelated functionality are usually too bikesheddable and contentious to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants