-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More library additions #1243
base: main
Are you sure you want to change the base?
More library additions #1243
Conversation
Co-authored-by: Thomas Draper <[email protected]>
Co-authored-by: Thomas Draper <[email protected]>
This reverts commit fb938cb.
Co-authored-by: Thomas Draper <[email protected]>
Co-authored-by: Thomas Draper <[email protected]>
a0840eb
to
08709e4
Compare
…es/coalton into more-library-additions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good-
I'm ready to approve it with
- An adjusted commit history (squash merges, reverts, wip commits)
- add some tests for new functions, especially in
ord-tree
andord-map
, potentially fortry-as
andunwrap-as
as well
@@ -218,12 +218,14 @@ does not have that suffix." | |||
(define-instance (Into Single-Float String) | |||
(define (into z) | |||
(lisp String (z) | |||
(cl:prin1-to-string z)))) | |||
(cl:format cl:nil "~F" z) | |||
#+ign(cl:prin1-to-string z)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ignores
I think we'll want to break this PR up into a few logical chunks. Large sweeping library additions of unrelated functionality are usually too bikesheddable and contentious to review. |
To be broken down into individual PRs and then closed.
Progress: