Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fromfrac function for converting fractions to dividable types #1310

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add fromfrac function for converting fractions to dividable types #1310

merged 1 commit into from
Oct 16, 2024

Conversation

Izaakwltn
Copy link
Collaborator

Closes #1309

@Izaakwltn Izaakwltn requested a review from jbouwman October 15, 2024 18:53
@Izaakwltn Izaakwltn mentioned this pull request Oct 15, 2024
Merged
@Izaakwltn
Copy link
Collaborator Author

@stylewarning is there a better name for this function?

jbouwman
jbouwman approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@jbouwman jbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, pending considering the function's name

@stylewarning
Copy link
Member

fromfrac? a sort of analog of fromint?

maybe that can go into the docs too

@Izaakwltn Izaakwltn force-pushed the fraction-conversion branch 2 times, most recently from 78529c2 to 96c2a55 Compare October 16, 2024 18:13
stylewarning
stylewarning requested changes Oct 16, 2024
View reviewed changes
library/math/real.lisp Outdated Show resolved Hide resolved
docs/intro-to-coalton.md Outdated Show resolved Hide resolved
@Izaakwltn Izaakwltn force-pushed the fraction-conversion branch 2 times, most recently from bbc2857 to f5015b2 Compare October 16, 2024 19:39
@Izaakwltn Izaakwltn changed the title Add realize function for converting fractions to dividable types Add fromfrac function for converting fractions to dividable types Oct 16, 2024
@Izaakwltn Izaakwltn force-pushed the fraction-conversion branch from f5015b2 to 7987a7c Compare October 16, 2024 19:44
stylewarning
stylewarning approved these changes Oct 16, 2024
View reviewed changes
docs/intro-to-coalton.md Outdated Show resolved Hide resolved
@Izaakwltn Izaakwltn force-pushed the fraction-conversion branch from 7987a7c to 75c34e1 Compare October 16, 2024 22:40
@stylewarning stylewarning merged commit 7fc91f8 into main Oct 16, 2024
33 checks passed
@stylewarning stylewarning deleted the fraction-conversion branch October 16, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbouwman jbouwman jbouwman approved these changes

@stylewarning stylewarning stylewarning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interface for converting Fractions to other types
3 participants
@Izaakwltn @stylewarning @jbouwman