Change Quantization from type to struct; doc upgrade
#1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1308 |
Izaakwltn
commented
Oct 15, 2024
stylewarning
requested changes
Oct 16, 2024
Izaakwltn
force-pushed
the
quant-struct
branch
3 times, most recently
from
d33dec0 to
d5d7682
Compare
Izaakwltn
force-pushed
the
quant-struct
branch
from
d5d7682 to
35c657d
Compare
stylewarning
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Quantization is a type with a single constructor, all the documentation is stuffed in the initial docstring. This moves documentation onto individual, named fields in a coalton struct