Ad4m launcher now works on windows #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADAM Layer Version 0.6.0
jdeepee
reviewed
Oct 5, 2023
There was a problem hiding this comment.
🔥 Lots of work here thanks @fayeed !
I have a few questions; I believe I tried before updating to the latest deno version but found that imports with the node prefix like: 'node:os' were not able to be imported due to the module loaders we use not being compatible. Was this somehow fixed in the deno versions, was the loader added by default?
|
Yeah, it's using the latest deno which was released a week ago, also had to set global variables manually since we dont have edit: Also had problem with dynamic imports so even if we used |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node:specifier to work in deno.