Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Notifications through SDNA triggers 1 - base implementation #475

Merged
merged 41 commits into from
May 23, 2024

Conversation

lucksus
Copy link
Member

@lucksus lucksus commented Apr 25, 2024

First half of: #363

  • spec out all the needed functions / interfaces
  • add new functions to Ad4mClient
  • types/handler boilerplate
  • implement notification trigger in ad4m executor

This adds the core functionality for ADAM Notifications, i.e. apps registering notifications, executor sending a signal, waiting for the user to confirm the notification install request and then check the notification prolog query on every perspective change - and eventually send out the notification through a subscription.

Whats missing for a complete implementation:

  • notification webhook push
  • UI in ADAM Launcher to deal with notification install requests

lucksus added 30 commits April 25, 2024 21:19
@lucksus lucksus marked this pull request as ready for review May 21, 2024 12:22
@lucksus lucksus changed the title App Notifications through SDNA triggers App Notifications through SDNA triggers 1 - base implementation May 23, 2024
@lucksus lucksus merged commit fdc7a83 into dev May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants