chore: Update from _rust/main template #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
epage
commented
Apr 26, 2024
epage
commented
- Tests created for any new feature or regression tests for bugfixes.
…thon-5.x chore(deps): update actions/setup-python action to v5
…tion-3.x chore(deps): update github/codeql-action action to v3
…n-3.x chore(deps): Update pre-commit/action action to v3.0.1
We might want to hold one or the other back
Now that we run clippy on stable, we can do this
This works well when a package is a safe abstraction but to universally apply in a template to all members of a workspace doesn't make sense.
While there is a config for ignoring these in tests, it doesn't help with examples.
Without automated checks, this will make it harder to track breaking changes.
This also fires in examples and other places. While docs in examples would be nice, it isn't universally applicable and `allow`s would undermine the examples.
chore(ci): Ensure CI job always runs
The overhead for MSRV bumping is a lot lower and its annoying merging all of the PRs (and I don't want these auto-merged)
Want to add this back in later but this is slowing down migration of my repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.