Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Transaction fee confirmation #108

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AndreKR
Copy link

@AndreKR AndreKR commented Nov 30, 2017

This adds a dialog to confirm transactions that cost a transaction fee.

Confirmation implemented for operations:

  • Alias change
  • Timestamping

Closes #67

@AndreKR AndreKR requested review from Patricia92 and titusz November 30, 2017 11:27
app/settings.py Outdated

class Settings(QSettings):
def __init__(self):
super().__init__('Content-Blockchain', 'Coblo')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreKR AndreKR changed the title Transaction fee confirmation WIP: Transaction fee confirmation Dec 1, 2017
@AndreKR
Copy link
Author

AndreKR commented Dec 1, 2017

@titusz Did you say there is an API request to get the fee per byte that the node would use? I can't find it. You also said something about settxfee? Where do you find these things? :p

@titusz
Copy link
Member

titusz commented Dec 1, 2017

@AndreKR MultiChain api is mostly compatible with Bitcoin. There is a help method on the API itself. See: https://chainquery.com/bitcoin-api/settxfee and https://chainquery.com/bitcoin-api/estimatefee
MultiChain specific API methods are documented here: https://www.multichain.com/developers/json-rpc-api/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants