DBG - break line that coverage says is not executed #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listening address is most likely 127.0.0.1 (libvirt default) or 0.0.0.0 (yolo config). Neither of these works remotely. Let's tell the remote viewer some address that has a chance of working. More complicated setups, like a bastion host or connecting via SSH inside Cockpit, might not work because of networking routing challanges, but at least we get better error messages like "No route to host" etc. Also, with the libvirt default of only listening on 127.0.0.1, no remote connection will work. But again, we now at least get the expected "Connection refused" error message.
cockpituous
reviewed
Jan 28, 2025
Comment on lines
+96
to
+97
| if (app.startsWith("cockpit+=")) { | ||
| address = "wrong:" + app.substr(9); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
There was a problem hiding this comment.
The test failure shows the wrong value that is computed here. Hmm. Maybe the coverage collection goes wrong across logouts?
Comment on lines
+102
to
+105
| address = cockpit.transport.host; | ||
| const pos = address.indexOf("@"); | ||
| if (pos >= 0) { | ||
| address = address.substr(pos + 1); |
There was a problem hiding this comment.
These 4 added lines are not executed by any test.
There was a problem hiding this comment.
This is expected, the test aborts before reaching the part that executes this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.