consoles: Redesign #2008
Draft
consoles: Redesign #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvollmer
force-pushed
the
console-redesign
branch
2 times, most recently
from
69dcfd9 to
77c4eb9
Compare
This was referenced Feb 4, 2025
mvollmer
force-pushed
the
console-redesign
branch
from
77c4eb9 to
0fe5bbc
Compare
This was referenced Feb 11, 2025
mvollmer
force-pushed
the
console-redesign
branch
2 times, most recently
from
f65bf5f to
ace6a87
Compare
mvollmer
force-pushed
the
console-redesign
branch
3 times, most recently
from
165110f to
4f73613
Compare
mvollmer
force-pushed
the
console-redesign
branch
2 times, most recently
from
5137d12 to
8128512
Compare
mvollmer
force-pushed
the
console-redesign
branch
2 times, most recently
from
a363668 to
ae64118
Compare
1 task
- A ToggleGroup in the Card header is used to switch consoles - The console switcher is also there for shut-off machines. This gives us a place type-specific actions that also make sense for a shut-off machine, like editing VNC server settings. - The DesktopViewer is gone, but there is a footer with a "Launch viewer" button and a "How to connect" popover. - Actions for the Graphics console are collected into a kebab menu, with a separate one for "Send keys". - The expanded console has less UI around it, and it keeps the type that was active in the collapsed view. - When there is no actual console for a given type, there is now a EmptyState component where you can activate it. (VNC and serial) - It is possible to change VNC server settings via the "How to connect" popup. - The SPICE console invites you to replace it with VNC.
mvollmer
force-pushed
the
console-redesign
branch
from
ae64118 to
111442f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://www.youtube.com/watch?v=Y3Q3QcBU8vs
Screenshots:
Alternative:
The "edit" button will open the dialog immediately. The popover doesn't have the "Set port and password" button anymore. The "VNC address:port" part is there so that the user has a clue what it is they will be editing when clicking on "edit".
I think this puts too much under the in-page viewer that is not immediately useful. You don't need to know address/port for the in-page viewer, and changing port or password has no effect on the in-page viewer. You don't need to know address/port for "Launch viewer" button, and changing the port has no effect on it.