package.json: replace single lodash user to a simple string replace

lodash is a quite big module (4.9M) for only one simple test loader where it uses only the template function. We will still have lodash in our `node_modules` sadly, as @patternfly/react-table imports it. Hopefully PatternFly can in the future move to es-toolkit once it has implemented all of required lodash functions.
cockpit-project · Jul 26, 2024 · 01b9c5e · 01b9c5e
1 parent 85e38aa
commit 01b9c5e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/node_modules b/node_modules
diff --git a/package.json b/package.json
@@ -49,7 +49,6 @@
     "glob": "7.2.3",
     "htmlparser": "1.7.7",
     "jed": "1.1.1",
-    "lodash": "4.17.21",
     "qunit": "2.21.0",
     "qunit-tap": "1.5.1",
     "sass": "1.77.6",

diff --git a/pkg/lib/esbuild-test-html-plugin.js b/pkg/lib/esbuild-test-html-plugin.js
@@ -2,8 +2,6 @@ import fs from 'node:fs';
 import path from 'node:path';
 import process from 'node:process';
 
-import _ from 'lodash';
-
 const srcdir = process.env.SRCDIR || '.';
 const libdir = path.resolve(srcdir, "pkg", "lib");
 
@@ -14,11 +12,9 @@ export const cockpitTestHtmlPlugin = ({ testFiles }) => ({
             const data = fs.readFileSync(path.resolve(libdir, "qunit-template.html.in"), "utf8");
             testFiles.forEach(file => {
                 const test = path.parse(file).name;
-                const output = _.template(data.toString())({
-                    title: test,
-                    builddir: file.split("/").map(() => "../").join(""),
-                    script: test + '.js',
-                });
+                const builddir = file.split("/").map(() => "../").join("");
+                const output = data.toString().replace("%title%", test).replace("%builddir%", builddir)
+                        .replace("%script%", test + '.js');
                 const outdir = './qunit/' + path.dirname(file);
                 const outfile = test + ".html";
 

diff --git a/pkg/lib/qunit-template.html.in b/pkg/lib/qunit-template.html.in
@@ -21,9 +21,9 @@
 <head>
     <meta charset="utf-8" />
     <title><%= title %></title>
-    <link rel="stylesheet" href="<%= title %>.css" type="text/css" />
-    <script src="<%= builddir %>dist/base1/cockpit.js"></script>
-    <script src="<%= script %>"></script>
+    <link rel="stylesheet" href="%title%.css" type="text/css" />
+    <script src="%builddir%dist/base1/cockpit.js"></script>
+    <script src="%script%"></script>
 </head>
 <body class="pf-v5-m-tabular-nums">
     <h1 id="qunit-header"><%= title %></h1>