session: Only support for cert auth with cockpit-session.socket

This avoids an alternative code path which is unlikely to happen in
practice, and which we don't test anywhere.

src/session/client-certificate.c

@@ -367,40 +367,39 @@ cockpit_session_client_certificate_map_user (const char *client_certificate_file
       return NULL;
     }
 
-  /* check if stdin is a Unix socket; then we are being called via cockpit-session@.service and need to
-   * check the cgroup of our peer */
+  /* We only support being called via cockpit-session.socket (i.e. Unix socket).
+   * We need to check the cgroup of cockpit-ws (our peer) */
   struct ucred ucred;
   socklen_t ucred_len = sizeof ucred;
-  int ws_pid_dirfd;
-  if (getsockopt (STDIN_FILENO, SOL_SOCKET, SO_PEERCRED, &ucred, &ucred_len) == 0)
+  if (getsockopt (STDIN_FILENO, SOL_SOCKET, SO_PEERCRED, &ucred, &ucred_len) != 0)
     {
-      /* this is an inout parameter, be extra suspicious */
-      assert (ucred_len >= sizeof ucred);
-      debug ("unix socket mode, reading cgroup from peer pid %d", ucred.pid);
-      ws_pid_dirfd = open_proc_pid (ucred.pid);
-      unsigned long ws_start_time = get_proc_pid_start_time (ws_pid_dirfd);
-
-      int my_pid_dirfd = open_proc_pid (getpid ());
-      unsigned long my_start_time = get_proc_pid_start_time (my_pid_dirfd);
-      close (my_pid_dirfd);
-
-      debug ("peer start time: %lu, my start time: %lu", ws_start_time, my_start_time);
-
-      /* Guard against pid recycling: If a malicious user captures ws, keeps the socket in a forked child and exits
-       * the original pid, they can trap a different user to login, get the old pid (pointing ot their cgroup), and
-       * capture their session. To prevent that, require that ws must have started earlier than ourselves. */
-      if (my_start_time < ws_start_time)
-        {
-          warnx ("start time of this process (%lu) is older than cockpit-ws (%lu), pid recycling attack?",
-                  my_start_time, ws_start_time);
-          close (ws_pid_dirfd);
-          return NULL;
-        }
+        debug ("failed to read stdin peer credentials: %m; not in socket mode?");
+        warnx ("Certificate authentication only supported with cockpit-session.socket");
+        return NULL;
+    }
+
+  /* this is an inout parameter, be extra suspicious */
+  assert (ucred_len >= sizeof ucred);
+  debug ("unix socket mode, reading cgroup from peer pid %d", ucred.pid);
+  int ws_pid_dirfd = open_proc_pid (ucred.pid);
+  unsigned long ws_start_time = get_proc_pid_start_time (ws_pid_dirfd);
+
+  int my_pid_dirfd = open_proc_pid (getpid ());
+  unsigned long my_start_time = get_proc_pid_start_time (my_pid_dirfd);
+  close (my_pid_dirfd);
+
+  debug ("peer start time: %lu, my start time: %lu", ws_start_time, my_start_time);
+
+  /* Guard against pid recycling: If a malicious user captures ws, keeps the socket in a forked child and exits
+  * the original pid, they can trap a different user to login, get the old pid (pointing ot their cgroup), and
+  * capture their session. To prevent that, require that ws must have started earlier than ourselves. */
+  if (my_start_time < ws_start_time)
+    {
+      warnx ("start time of this process (%lu) is older than cockpit-ws (%lu), pid recycling attack?",
+              my_start_time, ws_start_time);
+      close (ws_pid_dirfd);
+      return NULL;
     }
-  else {
-    ws_pid_dirfd = open_proc_pid (getpid ());
-    debug ("failed to read stdin peer credentials: %m; not in socket mode, reading cgroup from my own pid %d", ws_pid_dirfd);
-  }
 
   size_t ws_cgroup_length;
   char *ws_cgroup = read_proc_pid_cgroup (ws_pid_dirfd, &ws_cgroup_length);