-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Make some stratis tests nondestructive #19487
Conversation
Hmm, I could avoid some pixel noise by keeping Update: Done. |
c3bbe1a
to
f7ea2a0
Compare
Works on our CI now, but still fails on TF. Missing stratis dependency at least. |
ea82fe6
to
7d34829
Compare
This is a "fun" failure. There is some leaked /dev/loop12 (possibly from Update: This debug log shows that it's not a leak, it's just that losetup decides to actually allocate these names:
I'll try to fix them. |
test{Basic,Alerts,Cli} don't reboot and thus can run in our nondestructive VMs and on the Testing Farm. Move the others into a new TestStorageStratisReboot test class (that way around, the pixel tests have a lot less renaming noise). Change them to use loop devices, and ensure that failed tests clean up after themselves by stopping+destroying all leftover pools and creating mount points in vm_tmpdir. Change the test to always start stratisd.service, as the newly installed package in TF doesn't auto-start the unit. This paves the way for doing reverse dependency testing for stratis changes. https://issues.redhat.com/browse/COCKPIT-1070
The redesign will fix this! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
test{Basic,Alerts,Cli} don't reboot and thus can run in our nondestructive VMs and on the Testing Farm. Move the others into a new TestStorageStratisReboot test class (that way around, the pixel tests have a lot less renaming noise). Change them to use loop devices, and ensure that failed tests clean up after themselves by stopping+destroying all leftover pools and creating mount points in vm_tmpdir.
This paves the way for doing reverse dependency testing for stratis changes.
https://issues.redhat.com/browse/COCKPIT-1070
There's unfortunately some pixel noise, as the dialog previously had the "QEMU ..." name, and now with the loop devices they don't have a serial/label; and there's one rename.