selinux: Move update-motd out of cockpit_ws_t #21332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script has nothing to do with cockpit-ws, so stop putting it into the same security domain. We don't need to introduce a new one, just use the standard `shell_exec_t`. It's just a short-lived helper script with no user input, this doesn't justify its own policy. This may also help with certain configurations where `hostname` wants to read /proc. https://bugzilla.redhat.com/show_bug.cgi?id=2274774
jelly
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script has nothing to do with cockpit-ws, so stop putting it into the same security domain. We don't need to introduce a new one, just use the standard
shell_exec_t. It's just a short-lived helper script with no user input, this doesn't justify its own policy.This may also help with certain configurations where
hostnamewants to read /proc.https://bugzilla.redhat.com/show_bug.cgi?id=2274774