Skip to content

Commit

Permalink
Merge pull request #137782 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-24.1-137778

release-24.1: ttljob: fix frequency of logging progress
  • Loading branch information
rafiss authored Dec 19, 2024
2 parents 615d2c0 + 0682434 commit 509f1e6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/sql/ttl/ttljob/ttljob_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ func (t *ttlProcessor) work(ctx context.Context) error {
}
var rowsDeletedSoFar atomic.Int64
var spansProccessedSoFar atomic.Int64
var spansProccessedSinceLastLog atomic.Int64

// Log progress approximately every 1% of spans processed.
updateEvery := max(1, processorSpanCount/100)
Expand Down Expand Up @@ -211,6 +212,7 @@ func (t *ttlProcessor) work(ctx context.Context) error {
// add before returning err in case of partial success
rowsDeletedSoFar.Add(spanRowCount)
spansProccessedSoFar.Add(1)
spansProccessedSinceLastLog.Add(1)
if err != nil {
// Continue until channel is fully read.
// Otherwise, the keys input will be blocked.
Expand Down Expand Up @@ -247,8 +249,10 @@ func (t *ttlProcessor) work(ctx context.Context) error {
// If the span has no rows, we still need to increment the processed
// count.
spansProccessedSoFar.Add(1)
spansProccessedSinceLastLog.Add(1)
}
if spansProccessedSoFar.Load() >= updateEvery {
if spansProccessedSinceLastLog.Load() >= updateEvery {
spansProccessedSinceLastLog.Store(0)
if err := logProgress(); err != nil {
return err
}
Expand Down

0 comments on commit 509f1e6

Please sign in to comment.