Skip to content

Commit

Permalink
kvflowcontrolpb: rm unused type
Browse files Browse the repository at this point in the history
Epic: none
Release note: none
  • Loading branch information
pav-kv committed Dec 19, 2024
1 parent 6febaab commit acb087d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ func (a AdmittedRaftLogEntries) SafeFormat(w redact.SafePrinter, _ rune) {
a.RangeID, a.StoreID, admissionpb.WorkPriority(a.AdmissionPriority), a.UpToRaftLogPosition)
}

func (a AdmittedResponseForRange) String() string {
return redact.StringWithoutMarkers(a)
}

func (a AdmittedResponseForRange) SafeFormat(w redact.SafePrinter, _ rune) {
w.Printf("admitted-response (s%s r%s %s)", a.LeaderStoreID, a.RangeID, a.Msg.String())
}

func (a AdmittedState) String() string {
return redact.StringWithoutMarkers(a)
}
Expand Down
22 changes: 0 additions & 22 deletions pkg/kv/kvserver/kvflowcontrol/kvflowcontrolpb/kvflowcontrol.proto
Original file line number Diff line number Diff line change
Expand Up @@ -125,28 +125,6 @@ message RaftLogPosition {
uint64 index = 2;
}

// AdmittedResponseForRange is only used in RACv2. It contains a MsgAppResp
// from a follower to a leader, that was generated to advance the admitted
// vector for that follower, maintained by the leader.
//
// TODO(pav-kv): remove this type and use PiggybackedAdmittedState.
message AdmittedResponseForRange {
option (gogoproto.goproto_stringer) = false;

// LeaderStoreID is used to route the request when this message is received
// at the leader node.
uint64 leader_store_id = 1 [(gogoproto.customname) = "LeaderStoreID",
(gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.StoreID"];

// RangeID of the raft group to which the MsgAppResp is directed. Used for
// routing at the leader node.
int64 range_id = 2 [(gogoproto.customname) = "RangeID",
(gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.RangeID"];

// Msg is the MsgAppResp containing the admitted vector.
raftpb.Message msg = 3 [(gogoproto.nullable) = false];
}

// AdmittedState communicates a replica's vector of admitted log indices at
// different priorities to the leader of a range.
//
Expand Down

0 comments on commit acb087d

Please sign in to comment.