Skip to content

Commit

Permalink
kvcoord: deflake TestDistSenderReplicaStall
Browse files Browse the repository at this point in the history
The test runs with expiration leases but when fortification is enabled
the lease doesn't move off of the stalled replica because the
deadlocked leader doesn't step down while it's receiving store liveness
support.

This commit ensures fortification is off when expiration leases are used
for the test.

Fixes: #136564

Release note: None
  • Loading branch information
miraradeva committed Dec 10, 2024
1 parent 790ae95 commit ca0365c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func TestDistSenderReplicaStall(t *testing.T) {
// The lease won't move unless we use expiration-based leases. We also
// speed up the test by reducing various intervals and timeouts.
st := cluster.MakeTestingClusterSettings()
kvserver.ExpirationLeasesOnly.Override(ctx, &st.SV, true)
kvserver.OverrideDefaultLeaseType(ctx, &st.SV, roachpb.LeaseExpiration)
kvcoord.CircuitBreakersMode.Override(
ctx, &st.SV, kvcoord.DistSenderCircuitBreakersAllRanges,
)
Expand Down

0 comments on commit ca0365c

Please sign in to comment.