Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dev: remove
--strip=never
configuration from .bazelrc.user
Previously we unconditionally disabled stripping; however, this has a negative impact on performance (linking gets much more expensive when you do not strip). This is a cost we paid both locally in the development cycle as well as in CI. Removing this line from `.bazelrc` restores the default behavior of stripping iff the `compilation_mode` is `fastbuild` (which is the default). This will give developers the desired quick iteration behavior. You now have to opt into disabling stripping. Going forward we may evaluate if it is worth it to disable stripping for unit tests in CI to enable the use of `side-eye` (#136839). Until that point, there is no reason to disable stripping in this context. Stripping can be enabled with `--strip=always` or by passing `-c dbg` or `-c opt`. Notably, `dev build --cross`, the release process, and the `roachtest` nightlies all currently use `-c opt` when building, so there is nothing else to be done in these cases: they are all correctly not stripping. Epic: CRDB-17171 Release note: None
- Loading branch information