kvflowcontrol: re-enable kvadmission.flow_control.mode metamorphism #133854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kvoli
force-pushed
the
241030.rac2-enable-metamorphic-pull-mode
branch
2 times, most recently
from
935d98d to
9d3a771
Compare
The cluster setting `kvadmission.flow_control.mode` is used to control whether replication admission control applies to only elastic work, or applies to all work which sets an admission priority. The cluster setting was prior to cockroachdb#132125, metamorphic in tests, selecting either value with equal probability. cockroachdb#132125 disabled the metamorphism in order to prevent the newly introduced send queue / pull mode from being run unexpectedly, while still under testing. With testing now in place, re-enable the metamorphism, leaving the default value unchanged. Resolves: cockroachdb#132364 Release note: None
kvoli
force-pushed
the
241030.rac2-enable-metamorphic-pull-mode
branch
from
9d3a771 to
ce176ab
Compare
|
Not unexpectedly, some tests are failing. I suspect these tests exhaust tokens and delay admission. We should confirm whats happening. |
|
Closing in favor of merging both at the same time, the metamorphism change and the apply_to_all default value: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster setting
kvadmission.flow_control.modeis used to control whether replication admission control applies to only elastic work, or applies to all work which sets an admission priority.The cluster setting was prior to #132125, metamorphic in tests, selecting either value with equal probability. #132125 disabled the metamorphism in order to prevent the newly introduced send queue / pull mode from being run unexpectedly, while still under testing.
With testing now in place, re-enable the metamorphism, leaving the default value unchanged.
Resolves: #132364
Release note: None