backupccl: remove index/bytes columns from backup/restore return stmt #134516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
from
2ca481e to
1458584
Compare
kev-cao
requested review from
kyle-a-wong and
mgartner
and removed request for
a team
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
2 times, most recently
from
f324a46 to
c3441b0
Compare
This removes the index entries and bytes columns from the return result of a backup and restore. This columns do not inform the user of anything useful and only serve to mislead them. Fixes: cockroachdb#133053 Epic: None Release note (backward-incompatible change): Backup/restore statements no longer return index entries and bytes backed up/restored.
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
from
c3441b0 to
03e2409
Compare
kev-cao
commented
Dec 12, 2024
msbutler
approved these changes
Dec 12, 2024
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
from
03e2409 to
81922c1
Compare
kev-cao
requested review from
golgeek and
csgourav
and removed request for
a team
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
from
7c6fe60 to
9b67da0
Compare
msbutler
approved these changes
Dec 12, 2024
kev-cao
force-pushed
the
backupccl/remove-columns-backup-restore
branch
2 times, most recently
from
4909eac to
03e2409
Compare
|
TFTR! bors r=msbutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the index entries and bytes columns from the return result of a backup/restore/import. This columns do not inform the user of anything useful and only serve to mislead them.
Fixes: #133053
Epic: None
Release note (backward-incompatible change): Backup/restore/import statements no longer return index entries and bytes backed up/restored.