kv: only declare abort span key when txn has locks #136523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#122719. This commit updates DeclareKeysForBatch to only declare the abort span key when the transaction has acquired locks and will need to check the abort span. We were previously declaring the abort span key for all batches, even if we did not intend to check the abort span. This is a short-term patch until we get around to reworking abort span access more thoroughly (see cockroachdb#122719). ``` name old time/op new time/op delta Sysbench/KV/1node_local/oltp_read_only-10 334µs ± 4% 325µs ± 4% -2.63% (p=0.035 n=10+9) Sysbench/KV/1node_local/oltp_read_write-10 863µs ± 9% 860µs ±15% ~ (p=0.661 n=10+9) Sysbench/KV/1node_local/oltp_point_select-10 15.6µs ± 4% 15.9µs ±12% ~ (p=0.529 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 1.88ms ±26% 1.80ms ± 5% ~ (p=1.000 n=10+9) Sysbench/SQL/1node_local/oltp_read_write-10 4.22ms ± 5% 4.18ms ±11% ~ (p=0.400 n=9+10) Sysbench/SQL/1node_local/oltp_point_select-10 114µs ± 5% 120µs ±21% ~ (p=0.796 n=10+10) name old alloc/op new alloc/op delta Sysbench/KV/1node_local/oltp_read_write-10 487kB ± 0% 484kB ± 1% -0.55% (p=0.011 n=8+9) Sysbench/KV/1node_local/oltp_read_only-10 260kB ± 0% 259kB ± 1% -0.50% (p=0.011 n=8+10) Sysbench/SQL/1node_local/oltp_point_select-10 27.8kB ± 0% 27.6kB ± 0% -0.47% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 878kB ± 0% 876kB ± 0% -0.25% (p=0.003 n=10+10) Sysbench/SQL/1node_local/oltp_read_write-10 1.25MB ± 1% 1.25MB ± 1% ~ (p=0.146 n=10+8) Sysbench/KV/1node_local/oltp_point_select-10 4.68kB ± 1% 4.68kB ± 2% ~ (p=0.474 n=9+9) name old allocs/op new allocs/op delta Sysbench/KV/1node_local/oltp_read_only-10 522 ± 0% 507 ± 0% -2.72% (p=0.000 n=10+10) Sysbench/KV/1node_local/oltp_read_write-10 1.51k ± 0% 1.50k ± 0% -0.92% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_point_select-10 238 ± 0% 237 ± 0% -0.42% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 4.76k ± 0% 4.74k ± 0% -0.39% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_write-10 7.55k ± 0% 7.53k ± 0% -0.24% (p=0.003 n=10+10) Sysbench/KV/1node_local/oltp_point_select-10 29.0 ± 0% 29.0 ± 0% ~ (all equal) ``` Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
tbg
approved these changes
Dec 3, 2024
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
136523: kv: only declare abort span key when txn has locks r=nvanbenschoten a=nvanbenschoten Informs #122719. This commit updates `DeclareKeysForBatch` to only declare the abort span key when the transaction has acquired locks and will need to check the abort span. We were previously declaring the abort span key for all batches, even if we did not intend to check the abort span. This is a short-term patch until we get around to reworking abort span access more thoroughly (see #122719). ``` name old time/op new time/op delta Sysbench/KV/1node_local/oltp_read_only-10 334µs ± 4% 325µs ± 4% -2.63% (p=0.035 n=10+9) Sysbench/KV/1node_local/oltp_read_write-10 863µs ± 9% 860µs ±15% ~ (p=0.661 n=10+9) Sysbench/KV/1node_local/oltp_point_select-10 15.6µs ± 4% 15.9µs ±12% ~ (p=0.529 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 1.88ms ±26% 1.80ms ± 5% ~ (p=1.000 n=10+9) Sysbench/SQL/1node_local/oltp_read_write-10 4.22ms ± 5% 4.18ms ±11% ~ (p=0.400 n=9+10) Sysbench/SQL/1node_local/oltp_point_select-10 114µs ± 5% 120µs ±21% ~ (p=0.796 n=10+10) name old alloc/op new alloc/op delta Sysbench/KV/1node_local/oltp_read_write-10 487kB ± 0% 484kB ± 1% -0.55% (p=0.011 n=8+9) Sysbench/KV/1node_local/oltp_read_only-10 260kB ± 0% 259kB ± 1% -0.50% (p=0.011 n=8+10) Sysbench/SQL/1node_local/oltp_point_select-10 27.8kB ± 0% 27.6kB ± 0% -0.47% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 878kB ± 0% 876kB ± 0% -0.25% (p=0.003 n=10+10) Sysbench/SQL/1node_local/oltp_read_write-10 1.25MB ± 1% 1.25MB ± 1% ~ (p=0.146 n=10+8) Sysbench/KV/1node_local/oltp_point_select-10 4.68kB ± 1% 4.68kB ± 2% ~ (p=0.474 n=9+9) name old allocs/op new allocs/op delta Sysbench/KV/1node_local/oltp_read_only-10 522 ± 0% 507 ± 0% -2.72% (p=0.000 n=10+10) Sysbench/KV/1node_local/oltp_read_write-10 1.51k ± 0% 1.50k ± 0% -0.92% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_point_select-10 238 ± 0% 237 ± 0% -0.42% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_only-10 4.76k ± 0% 4.74k ± 0% -0.39% (p=0.000 n=10+10) Sysbench/SQL/1node_local/oltp_read_write-10 7.55k ± 0% 7.53k ± 0% -0.24% (p=0.003 n=10+10) Sysbench/KV/1node_local/oltp_point_select-10 29.0 ± 0% 29.0 ± 0% ~ (all equal) ``` Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed: |
|
Flaked on #136582. bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #122719.
This commit updates
DeclareKeysForBatchto only declare the abort span key when the transaction has acquired locks and will need to check the abort span. We were previously declaring the abort span key for all batches, even if we did not intend to check the abort span.This is a short-term patch until we get around to reworking abort span access more thoroughly (see #122719).
Release note: None