Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql/server: Fix license disable bug for single node clusters #137010

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 9, 2024

Backport 1/1 commits from #136926 on behalf of @spilchen.

/cc @cockroachdb/release


License enforcement is intended to be disabled for single-node setups. However, when starting CockroachDB with start-single-node, license enforcement was only disabled on the initial startup. Subsequent restarts of the cluster did not correctly disable licensing. This fix addresses and resolves that issue.

This should be backported all the way back to 23.1.

Epic: None
Release note (bug fix): Fixed an issue where license enforcement was not consistently disabled for single-node clusters started with start-single-node, ensuring proper behavior on cluster restarts.


Release justification: Important bug fix so that single node servers can run without license enforcement.

License enforcement is intended to be disabled for single-node setups.
However, when starting CockroachDB with start-single-node, license
enforcement was only disabled on the initial startup. Subsequent
restarts of the cluster did not correctly disable licensing. This fix
addresses and resolves that issue.

Epic: None
Release note (bug fix): Fixed an issue where license enforcement was not
consistently disabled for single-node clusters started with
start-single-node, ensuring proper behavior on cluster restarts.
@blathers-crl blathers-crl bot requested review from a team as code owners December 9, 2024 12:26
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-136926 branch from d501a5e to 2ea6e3e Compare December 9, 2024 12:26
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 9, 2024
Copy link
Author

blathers-crl bot commented Dec 9, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 9, 2024
Copy link
Author

blathers-crl bot commented Dec 9, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@spilchen spilchen requested a review from rafiss December 9, 2024 14:08
@spilchen spilchen requested a review from a team as a code owner December 11, 2024 18:58
@spilchen spilchen force-pushed the blathers/backport-release-24.1-136926 branch from 5e947fa to 2ea6e3e Compare December 11, 2024 19:54
@spilchen spilchen merged commit 2173504 into release-24.1 Dec 12, 2024
33 of 34 checks passed
@spilchen spilchen deleted the blathers/backport-release-24.1-136926 branch December 12, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants