kvserver/rangefeed: add basic unbuf reg metrics #137015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
wenyihu6
force-pushed
the
unbufregmetrics
branch
5 times, most recently
from
63e2a8a to
1a389b5
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
wenyihu6
force-pushed
the
unbufregmetrics
branch
2 times, most recently
from
28f682c to
f727e13
Compare
|
@stevendanna I remember you mentioned having a few specific metrics in mind that you'd like to include. These are just four basic ones that could provide some initial observability if people want to test this feature. |
wenyihu6
force-pushed
the
unbufregmetrics
branch
3 times, most recently
from
0d13ac1 to
c0ae144
Compare
This patch introduces two new metrics -
kv.rangefeed.{buffered,unbuffered}_registrations. They track the number of
corresponding active buffered and unbuffered rangefeeds subscribed on
replicas.
Part of: cockroachdb#129816
Release note: none
This patch introduces a new metric, kv.rangefeed.output_loop_nanos, which tracks the duration of the per-range, per-registration runOutputLoop goroutine. This goroutine is expected to be short-lived for unbuffered registrations, while it remains long-lived for buffered registrations. Note that this metric is only non-zero for unbuffered registrations. Part of: cockroachdb#129816 Release note: none
This patch refactors rangefeed metrics in node.Metrics into a dedicated StreamManagerMetrics struct. This improves modularity and aligns with future additions like BufferedSenderMetrics. Epic: none Release note: none
wenyihu6
force-pushed
the
unbufregmetrics
branch
from
c0ae144 to
6405648
Compare
This patch adds a new metric, rangefeed.buffered_sender.queue_size, to track the number of entries pending in the buffered sender queue waiting to be sent to rpc stream. Part of: cockroachdb#129816 Release note: none
wenyihu6
force-pushed
the
unbufregmetrics
branch
from
6405648 to
811dd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kvserver/rangefeed: add kv.rangefeed.{buffered,unbuffered}_registrations
This patch introduces two new metrics -
kv.rangefeed.{buffered,unbuffered}_registrations. They track the number of
corresponding active buffered and unbuffered rangefeeds subscribed on the
replica.
Part of: #135332
Release note: none
kvserver/rangefeed: add kv.rangefeed.output_loop_nanos
This patch introduces a new metric, kv.rangefeed.output_loop_nanos, which tracks
the duration of the per-range, per-registration runOutputLoop goroutine. This
goroutine is expected to be short-lived for unbuffered registrations, while it
remains long-lived for buffered registrations. Note that this metric is only
non-zero for unbuffered registrations.
Part of: #135332
Release note: none
kvserver/rangefeed: add StreamManagerMetrics
This patch refactors rangefeed metrics in node.Metrics into a dedicated
StreamManagerMetrics struct. This improves modularity and aligns with future
additions like BufferedSenderMetrics.
Epic: none
Release note: none
kvserver/rangefeed: add rangefeed.buffered_sender.queue_size
This patch adds a new metric, rangefeed.buffered_sender.queue_size, to track the
number of entries pending in the buffered sender queue waiting to be sent to rpc
stream.
Part of: #129816
Release note: none