server: deprecate database and index fields on HotRanges proto #137043
+86
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angles-n-daemons
requested review from
dhartunian
and removed request for
a team
|
This change is |
xinhaoz
reviewed
Dec 10, 2024
pkg/server/serverpb/status.proto
Outdated
| @@ -1484,9 +1484,9 @@ message HotRangesResponseV2 { | |||
| // table_name has been deprecated in favor of tables = 16; | |||
| string table_name = 4 [deprecated = true]; | |||
| // database_name has been deprecated in favor of databases = 17; | |||
| string database_name = 5; | |||
| string database_name = 5 [deprecated = true]; | |||
There was a problem hiding this comment.
I think typically we opt for reserved - is there a reason we're doing a softer deprecation here?
There was a problem hiding this comment.
No reason other than muscle memory - I'll change this.
angles-n-daemons
force-pushed
the
hot-ranges-proto-deprecate-db-index
branch
4 times, most recently
from
a8f65bb to
9fb2ee0
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
angles-n-daemons
force-pushed
the
hot-ranges-proto-deprecate-db-index
branch
from
9fb2ee0 to
d00c8c9
Compare
angles-n-daemons
force-pushed
the
hot-ranges-proto-deprecate-db-index
branch
from
d00c8c9 to
421b874
Compare
angles-n-daemons
requested review from
arjunmahishi and
aa-joshi
and removed request for
a team
angles-n-daemons
force-pushed
the
hot-ranges-proto-deprecate-db-index
branch
from
421b874 to
bfebae3
Compare
In changeset cockroachdb#134106, the database, table, and index fields of the HotRanges protobuf were moved to synonymous keys so that there could be multiple of each. This means a hot range could now have multiple indexes, tables and databases contained within it in the UI. During this change however, only the old table key of the protobuf was deprecated, the database and index fields were not flagged for deprecation. This small change fixes this oversight. Release note: None
angles-n-daemons
force-pushed
the
hot-ranges-proto-deprecate-db-index
branch
from
bfebae3 to
ca76f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server: deprecate database and index fields on HotRanges proto
In changeset #134106, the database, table, and index fields of the HotRanges protobuf were moved to synonymous keys so that there could be multiple of each. This means a hot range could now have multiple indexes, tables and databases contained within it in the UI.
During this change however, only the old table key of the protobuf was deprecated, the database and index fields were not flagged for deprecation. This small change fixes this oversight.
Epic: CRDB-43151
Release note: None