Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump dependency for code-cover-pubish GH action #137298

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

srosenberg
Copy link
Member

@srosenberg srosenberg commented Dec 11, 2024

actions/github-script started failing auth on downloadArtifact
as of several weeks ago. Bumping to the latest version (v7.0.1)
seems to resolve it.

Epic: none
Release note: None

@srosenberg srosenberg requested a review from a team as a code owner December 11, 2024 20:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator

Seems to make no difference? https://github.com/cockroachdb/cockroach/actions/runs/12284311045

@srosenberg srosenberg force-pushed the sr/code_cover_publish_bump branch from 2da0abc to 6000bf4 Compare December 11, 2024 20:28
Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, I forgot that the workflow runs from master, so you need to merge this to see if it works.

`actions/github-script` started failing auth on `downloadArtifact`
as of several weeks ago. Bumping to the latest version (v7.0.1)
seems to resolve it.

Epic: none

Release note: None
@srosenberg srosenberg force-pushed the sr/code_cover_publish_bump branch from 6000bf4 to 975c428 Compare December 11, 2024 22:35
@srosenberg
Copy link
Member Author

TFTR!

bors r=rickystewart,RaduBerinde

@craig craig bot merged commit 00264aa into cockroachdb:master Dec 11, 2024
22 checks passed
golgeek added a commit to golgeek/cockroach that referenced this pull request Dec 13, 2024
Before the fix provided byn cockroachdb#137298, this Github Action was silently
failing.

This PR configures a call to DeadManSnitch service to report when the
Github Action was last successful. The service is configured to alert
CRL internal team when no ping was seen in the last 24h.

Epic: none
Release note: None

Signed-off-by: Ludovic Leroux <[email protected]>
golgeek added a commit to golgeek/cockroach that referenced this pull request Dec 13, 2024
Before the fix provided by cockroachdb#137298, this Github Action was silently
failing.

This PR configures a call to DeadManSnitch service to report when the
Github Action was last successful. The service is configured to alert
CRL internal team when no ping was seen in the last 24h.

Epic: none
Release note: None

Signed-off-by: Ludovic Leroux <[email protected]>
craig bot pushed a commit that referenced this pull request Dec 13, 2024
137412: ci: deadmansnitch for code-cover-publish Github Action r=srosenberg,rickystewart,DarrylWong a=golgeek

Before the fix provided by #137298, this Github Action was silently failing.

This PR configures a call to DeadManSnitch service to report when the Github Action was last successful. The service is configured to alert CRL internal team when no ping was seen in the last 24h.

Epic: none
Release note: None

Co-authored-by: Ludovic Leroux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants